fix: always use RCT_USE_RN_DEP and RCT_USE_PREBUILT_RNCORE values when passed
#613
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@war-in is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
|
I'm also not sure if I have to cast envs to string but did it to stay aligned with the previous code |
|
@war-in I'll merge and release this one soon! |
|
@war-in I released |
|
@szymonrybczak thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rock should always use
RCT_USE_RN_DEP&RCT_USE_PREBUILT_RNCOREwhen passed. Current implementation (||) takes value fromusePrebuiltReactNativewhen envs are set to 0 by the user, which basically blocks us from disabling the prebuild artefactscc @thymikee as you mentioned that this is an expected behaviour here 🙏 Let me know if I missed something!
Note
Respect
RCT_USE_RN_DEPandRCT_USE_PREBUILT_RNCOREenv vars when set; fall back to prebuilt RN defaults only when unset.packages/platform-apple-helpers/src/lib/utils/pods.tsto always use provided env values forRCT_USE_RN_DEPandRCT_USE_PREBUILT_RNCORE(treat0as valid), defaulting to prebuilt RN only when envs are undefined.@rock-js/platform-apple-helpers.Written by Cursor Bugbot for commit 9ed5d05. This will update automatically on new commits. Configure here.